Support a trusted CA for API-key and no-credentials Connections - #546
Open
aldredb wants to merge 3 commits into
Open
Support a trusted CA for API-key and no-credentials Connections#546aldredb wants to merge 3 commits into
aldredb wants to merge 3 commits into
Conversation
Only mutual-TLS Connections could trust a private CA, via MutualTLSSecretRef's own ca.crt key. API-key and no-credentials Connections had no such option, forcing self-hosted clusters with a private CA onto a process-wide SSL_CERT_FILE override, which replaces rather than extends the system trust store. - add ConnectionTLSConfig.CACertSecretRef, independent of AuthMode - extract mergeCACert from the existing mTLS logic and reuse it for API-key and no-credentials auth - error out (not silently skip) when the referenced secret has no ca.crt key - add the new field to ClientPoolKey so the client cache still invalidates correctly on a CA change
Collaborator
|
Hi @aldredb thank you for this PR. We'll get it reviewed as soon as we can. Do you have an issue open for this by any chance? |
jaypipes
requested changes
Aug 25, 2026
…ents - rename CACertSecretName to TLSCACertSecretName, matching TLSServerName - rename mergeCACert to TLSCertPool - say which auth modes CACertSecretRef applies to instead of "independent of AuthMode"
Contributor
Author
|
@jaypipes thanks for the review — addressed in a762022:
I left a question on the CEL validation thread. Ready for another look when you get a chance. |
jaypipes
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let API-key and no-credentials Connections trust a private CA, matching what mutual-TLS Connections already get via MutualTLSSecretRef's own ca.crt key.
ConnectionTLSConfig.CACertSecretRef, applicable when the auth mode is API key or no credentialsfetchClientUsingMTLSSecret) into a sharedTLSCertPoolhelper and reuse it across auth modesca.crtkeyClientPoolKeyso the client cache invalidates correctly when the CA changesWithout this, the only way to reach a Temporal server on a privately-signed certificate over API-key auth is a process-wide
SSL_CERT_FILEoverride on the controller — which replaces rather than extends the system trust store, and affects every Connection the controller manages, not just the one that needs it.