Repository navigation
fix(packaging): port PKGBUILD contract files to the canonical line (Refs #316, #342) - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs in the Arch/AUR PKGBUILD contract added by #343, found when the workflow first ran on GitHub:
.github/workflows/pkgbuild-contract.ymlto the canonical GitHub line, notpkgbuilds/terraphim-clients-bin/**ortests/test_pkgbuild_release_contract.py. The workflow therefore ran against files that do not exist on GitHub — the contract job failed withModuleNotFoundError: No module named tests.test_pkgbuild_release_contractand the Arch job with./pkgbuilds/terraphim-clients-bin/verify.sh: No such file or directory.python3 -m unittest tests.test_pkgbuild_release_contract, which requirestests/to be an importable package (there is notests/__init__.py). Switched topython3 -m unittest discover -s tests -p "test_pkgbuild_release_contract.py" -v, matching the canonicalci.ymlstyle.This ports the full #343 content to the canonical line and fixes the invocation.
Evidence
Refs terraphim-clients#316, #342.