Repository navigation
Replace search filters with chips and a labeled search field - #113
Merged
Merged
Conversation
Enter runs the same search as the button when the form is valid. Suitable, type, and date stay visible as chips that open a popover, and Created By sits above them. The dictation list preview is the last line of each row. Co-authored-by: Cursor <cursoragent@cursor.com>
SonarCloud treats the unhandled search() promise as a reliability bug. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Search request mapping is unchanged: type
Anyis sent asnull, SuitableAnyis still sent asAny, and a date of Any omitsminDate.Tests
npx ng test --browsers=ChromeHeadlessCI --watch=false --include='**/search-dictation.page.spec.ts' --include='**/dictation-list.spec.ts'— 16 passedTest evidence
Local app at
http://localhost:4200/search-dictation. Each clip opens the page, chooses Sentence and Senior Primary from the chips, shows the 3-character error forab, then searchesapple. iOS and Android are the same local app in Safari and Chrome at phone size. No native simulator was running.Web
web-desktop.mp4
iPhone (Safari)
ios-safari.mp4
Android (Chrome)
android-chrome.mp4
To show artifacts inline, enable in settings.