Repository navigation
Show a clearer no-results state on dictation search - #114
Merged
Merged
Conversation
Name the keyword and any Suitable, type, or date filters, and let learners loosen those filters or clear the search in one step. Co-authored-by: Timmy Wong <thcathy@gmail.com>
Share one filter reset for Soften filters and Clear, and leave the chips alone when the form is invalid. Co-authored-by: Timmy Wong <thcathy@gmail.com>
Keep the zero-hit message and Clear. Drop the button, its copy, and the shared reset that only Clear still used. Co-authored-by: Timmy Wong <thcathy@gmail.com>
Drop the keyword and filter line from the empty search card. Clear still resets the form. Co-authored-by: Timmy Wong <thcathy@gmail.com>
|
thcathy
marked this pull request as ready for review
October 7, 2026 14:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Search Dictation returns zero hits, the empty card says No dictation matched. and offers Clear. It does not repeat the keyword or list Suitable, Type, or date. The empty state lives on
/search-dictationonly.Clear resets the keyword, Created By, and the three chips, and removes the empty card. It does not run a search.
How to verify on /search-dictation
zzzzqqqxxx, with or without Suitable, Type, or date set. ExpectNo dictation matched.and Clear.Tests
npx ng test --browsers=ChromeHeadlessCI --watch=false --include='**/search-dictation.page.spec.ts' --include='**/dictation-list.spec.ts'19 specs passed.
no-dictation-matched.mp4
Empty search says No dictation matched
To show artifacts inline, enable in settings.