Repository navigation
Show search match counts and Previous/Next paging - #115
Merged
Merged
Conversation
…Next. Count the rows already returned by search, and say 50+ when that list hits the API cap. Co-authored-by: Timmy Wong <thcathy@gmail.com>
The count sits on the green header under Search Result, in the same card chrome as the list, instead of a separate line above the rows. Co-authored-by: Timmy Wong <thcathy@gmail.com>
Co-authored-by: Timmy Wong <thcathy@gmail.com>
Co-authored-by: Timmy Wong <thcathy@gmail.com>
|
thcathy
marked this pull request as ready for review
October 10, 2026 23:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Search Dictation now tells you how many exercises matched, and the pager says Previous / Next.
/dictation/searchalready returns (at most 50). It is just the range and the total:1–5 of 10. A full list says1–5 of 50+. Chinese uses1–5 / 10and1–5 / 50+.Tests
dictation-list.spec.tsandsearch-dictation.page.spec.ts: normal range, single page, under the cap, and the 50+ cap, plus Previous/Next disabled state. 28 passed.1–5 / 50+.English count right-aligned in the Search Result title bar
Traditional Chinese capped count right-aligned in the title bar
To show artifacts inline, enable in settings.