Skip to content

Show search match counts and Previous/Next paging - #115

Merged
thcathy merged 4 commits into
masterfrom
cursor/search-result-count-paging-fbab
Oct 10, 2026
Merged

thcathy merged 4 commits into
masterfrom
cursor/search-result-count-paging-fbab

Conversation

@thcathy

@thcathy thcathy commented Oct 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

Search Dictation now tells you how many exercises matched, and the pager says Previous / Next.

  • The count is taken from the list /dictation/search already returns (at most 50). It is just the range and the total: 1–5 of 10. A full list says 1–5 of 50+. Chinese uses 1–5 / 10 and 1–5 / 50+.
  • That count sits on the right of the green Search Result title bar, on the same line as the title.
  • Previous is disabled on the first page and Next on the last. My Records still uses Newer / Older.
  • English, Simplified Chinese, and Traditional Chinese strings are included. The no-results empty state is unchanged.

Tests

  • dictation-list.spec.ts and search-dictation.page.spec.ts: normal range, single page, under the cap, and the 50+ cap, plus Previous/Next disabled state. 28 passed.
  • Phone check at 390px: the title stays on the left and the count is on the right of the same green bar, in English and Traditional Chinese, including 1–5 / 50+.

English count right-aligned in the Search Result title bar
Traditional Chinese capped count right-aligned in the title bar

To show artifacts inline, enable in settings.

Open in Web Open in Cursor 

cursoragent and others added 4 commits October 8, 2026 00:00
…Next.

Count the rows already returned by search, and say 50+ when that list hits the API cap.

Co-authored-by: Timmy Wong <thcathy@gmail.com>
The count sits on the green header under Search Result, in the same card chrome as the list, instead of a separate line above the rows.

Co-authored-by: Timmy Wong <thcathy@gmail.com>
Co-authored-by: Timmy Wong <thcathy@gmail.com>
Co-authored-by: Timmy Wong <thcathy@gmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

@thcathy
thcathy marked this pull request as ready for review October 10, 2026 23:10
@thcathy
thcathy merged commit f5c560b into master Oct 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants