Repository navigation
Sync search filters to the URL - #116
Merged
Merged
Conversation
Reading q, suitable, and type on enter restores the search form and runs the search. Chip changes, search, and clear rewrite those params with replaceUrl. Co-authored-by: Timmy Wong <thcathy@gmail.com>
Read, compare, and write q, suitable, and type through SearchLink. A filter-only URL still searches, and it no longer stores an empty keyword. Co-authored-by: Timmy Wong <thcathy@gmail.com>
SonarCloud flagged find() on the history list because the result is only used as a boolean. Co-authored-by: Timmy Wong <thcathy@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Search Dictation now reads and writes
q,suitable, andtypeon/search-dictation.replaceUrl.Anyand blank values are omitted. Unknown suitable/type values become Any. A too-shortqshows the existing validation message and does not search.sortparam is left untouched./link/dictation-view/:id. This does not move state-onlyopenDictationcalls onto the id path.Tests
/link/dictation-view/{id}.e2e/search-dictation-query.spec.ts.Demo
Pasting
/search-dictation?q=apple&suitable=JuniorPrimary&type=Vocabrestores the keyword, the Junior Primary and Word chips, and the matching list.Deep-linked search for apple, Junior Primary, Word
To show artifacts inline, enable in settings.