Conversation
|
@jcisco22 Thanks for submitting! I can't see this project available for review. Could you please submit in the dashboard before we can approve 😁. |
🚀 Project Submitted!Thanks for submitting your project! I will review it soon. 📋 Please check the dashboard to make sure the project is marked as Pending. |
TheCSharpAcademy
left a comment
There was a problem hiding this comment.
@jcisco22 Thanks for submitting! Before we approve, please fix these important bugs:
❌ Duration isn't kept correct when updating a record. You correctly calculate duration during insertion:
string duration = (endTime - startTime).ToString();
But Update() only updates StartTime and EndTime:
UPDATE coding_tracker
SET StartTime = @StartTime,
EndTime = @EndTime
WHERE ID = @Id
This means an updated record can display its old duration with its new start/end times.
❌ End time can currently be earlier than start time. This is specifically called out in the project's validation tips. At the moment both times are individually valid, but there's no validation of their relationship.
For example, the program accepts:
Start: 18:00
End: 15:00
and will calculate a negative duration.
💁♂️If you have any questions, the best way to get help is in our Discord, in the #get-help-with-projects channel.
No description provided.