Skip to content

Project Done - Review - #282

Closed
Kerem1989 wants to merge 6 commits into
the-csharp-academy:mainfrom
Kerem1989:main
Closed

Kerem1989 wants to merge 6 commits into
the-csharp-academy:mainfrom
Kerem1989:main

Conversation

@Kerem1989

Copy link
Copy Markdown

No description provided.

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@Kerem1989 Project approved! Apologies for the delay😄✅ Unit testing challenge attempted! This is great to see. You have dedicated xUnit tests covering date formatting, abort behavior, valid chronological dates, equal dates, reversed times, and dates on an earlier day. 👩‍🎤

🥋And congratulations! You got your Olive Green belt!! 🫒🫒

Feedback
🔍I recommend is that you let users choose records using arrows, with the help of Spectre Console. This way you don't need to ask for the input of an Id when deleting/updating, which will improve the user experience a lot 💪

🔍❌ Update can create an invalid session. Creation correctly checks:

Validator.ValidateStartAndEndDate(
    codingSession.StartTime,
    codingSession.EndTime);

However, EditCodingSession doesn't perform that check after the user changes the start or end date. For example, an existing session could be:

Start: 2026-08-24 09:00
End:   2026-08-24 17:00

The user could edit the start to 2026-08-24 20:00. The application then calculates a negative duration and saves it.

🔍There's another small edge case: ValidateStartAndEndDate() currently considers identical start/end values valid. Your tests explicitly confirm that behavior. That creates a zero-minute coding session. The project only specifically says the end can't be before the start, so this isn't an approval blocker, but I'd consider whether a zero-duration coding session makes sense for your application.

🗺️ I noticed that the only courses you've completed so far are Introduction to Object-Oriented Programming and Intro to SQL. I'd highly recommend taking our LINQ Fundamentals course next. LINQ is one of the most important tools in modern C# and becoming comfortable with it will make your code much cleaner and more expressive.

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants