Skip to content

Finish App - #285

Closed
Dzemal-Kurtic wants to merge 5 commits into
the-csharp-academy:mainfrom
Dzemal-Kurtic:main
Closed

Dzemal-Kurtic wants to merge 5 commits into
the-csharp-academy:mainfrom
Dzemal-Kurtic:main

Conversation

@Dzemal-Kurtic

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy TheCSharpAcademy self-assigned this Sep 14, 2026
@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@Dzemal-Kurtic Project approved! 😄✅ Great job using Spectre Console and adding a timed session functionality. The UI looks great. 💪

🥋And congratulations! You got your Olive Green belt!! 🫒🫒

Feedback
🔍 I recommend you let users choose records using arrows, with the help of Spectre Console. This way you don't need to ask for the input of an Id when deleting/updating, which will improve the user experience a lot 💪

🔍When updating you're asking the user to input every property again. What's the difference between that and adding a new record? Ideally you want to let the users update just a single property or however many they want😁

🔍It's good practice to ask for confirmation upon deleting records.

🔍Unit tests would have been great for this project, particularly for testing your validation methods. I strongly recommend you always include Unit Tests from now on.

🔍When updating you're not checking if the end date is prior to the start date, which allows me to insert a negative time.

🗺️ I noticed that the only course you've completed so far is the Introduction to Object-Oriented Programming and Dependency Injection. I'd highly recommend taking our LINQ Fundamentals course next. LINQ is one of the most important tools in modern C# and becoming comfortable with it will make your code much cleaner and more expressive.

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants