fix(gateway): keep hard budgets conservative when stream usage is incomplete - #255
Open
islahuddinn wants to merge 1 commit into
Open
fix(gateway): keep hard budgets conservative when stream usage is incomplete#255islahuddinn wants to merge 1 commit into
islahuddinn wants to merge 1 commit into
Conversation
islahuddinn
force-pushed
the
fix/gateway-incomplete-stream-budget-248
branch
2 times, most recently
from
September 2, 2026 22:39
065a897 to
f90f7ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an Anthropic (or other streaming) provider connection drops after partial usage telemetry arrives, the gateway was reconciling hard-budget reservations down to that partial measured cost. That releases budget headroom the provider may still charge against.
This change tracks usage completeness separately from observed usage:
UsageTee.usageCompleteis set only on terminal provider usage framesbillableCostCents()keeps hard-budget reconciliation conservative when a provider-charged error ends with incomplete usagellm_requestsrow; only budget billing uses the preflight estimate when final usage is unknownFixes #248
Test plan
pnpm --filter @facility/gateway test(33 passed)billableCostCentsandusageCompleteMade with Cursor