Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Runtime dependencies appear incomplete for a clean install (notably denspart is imported unconditionally but not declared), which conflicts with the stated goal of enabling reliable releases/installs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR aims to support automated PyPI releases by cleaning up packaging metadata and making the Sphinx documentation version track repository tags.
Changes:
- Removes a stale commented install hint from
requirements.txt. - Removes a stale commented version line from
pyproject.toml. - Updates Sphinx
version/releaseto be derived from the latest git tag.
File summaries
| File | Description |
|---|---|
| requirements.txt | Removes a comment, but this is also where runtime deps are sourced for packaging. |
| pyproject.toml | Removes a commented version line while keeping dynamic versioning enabled. |
| doc/conf.py | Sets Sphinx version/release based on git tags via a helper function. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+48
to
+57
| def _git_tag_version(default='1.0.0'): | ||
| try: | ||
| tag = subprocess.check_output( | ||
| ['git', 'describe', '--tags', '--abbrev=0'], | ||
| cwd=os.path.abspath('..'), | ||
| stderr=subprocess.DEVNULL, | ||
| ) | ||
| return tag.decode('utf-8').strip().lstrip('v') or default | ||
| except Exception: | ||
| return default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable automatic PyPI release
Type of Changes
Please remove the lines that don't represent the type of your PR.
🪲 Bug Fix
📚 Documentation
🎨 Improve Format & Structure
🚀 Release
Related Issue
Closes #64