Fix Grid.moments Cartesian orders on 1D grids

[Copilot]

Grid.moments(..., type_mom="cartesian") raised AttributeError: module 'numpy' has no attribute 'int' on grids with 1D point arrays (shape (N, 1)), since np.int was removed in NumPy 1.24. The dim == 1 branch also returned the wrong shape (arange(0, order+1) instead of a single row), which would have broken np.vstack in Grid.moments even with a valid dtype.

• generate_orders_horton_order (src/grid/utils.py): dim == 1 branch now returns np.array([[order]]), matching the row shape produced by the dim == 2 and dim == 3 branches.
• Tests: added coverage for generate_orders_horton_order at dim=1/2/3, and a test_moments_cartesian case exercised across 1D/2D/3D Grid point arrays.

import numpy as np
from grid.basegrid import Grid

pts = np.linspace(-1, 1, 5)[:, None]
grid = Grid(pts, np.full(5, 0.4))
grid.moments(2, np.array([[0.0]]), pts[:, 0] ** 2, "cartesian")  # now returns correctly shaped moments

• Fixes Grid.moments with Cartesian orders fails on 1D grids #334

[Copilot]

Copilot review overview

🟢 Approval recommended

The implementation matches the documented order semantics and includes targeted regression coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes Cartesian moment-order generation for 1D grids while preserving multidimensional behavior.

Changes:

• Returns correctly shaped Cartesian orders for 1D grids.
• Adds utility and integration-level regression tests across 1D–3D grids.
• Ignores setuptools-scm’s generated version file.

File	Description
src/​grid/​utils.py	Corrects 1D Cartesian order generation.
src/​grid/​tests/​test_utils.py	Tests Cartesian orders across dimensions.
src/​grid/​tests/​test_grid.py	Tests Cartesian moments on 1D–3D grids.
.gitignore	Excludes generated version metadata.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[PaulWAyers]

Your thoughts @marco-2023 and/or @FarnazH ?

[PaulWAyers]

I think this is redundant with the other PR from the external contributor and can be closed in lieu of that, but let me know. I"m curious how good (or bad) direct Copilot contributions are.

[marco-2023]

@PaulWAyers, both branches solve the problem. I think #335 has a better test, and Copilot added an unnecessary commit. I would keep #335 and close this one.

[PaulWAyers]

Superseded by #335