Repository navigation
Fix FejerFirst and FejerSecond implementations - #339
Merged
Merged
Conversation
The test was a clone of the erroneous implementation.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The FejerFirst regression remains untested because the existing even-sized test cannot detect the corrected term.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Corrects off-by-one errors in Fejér quadrature weight calculations and aligns related documentation.
Changes:
- Includes the final Fejér summation term.
- Clarifies formulas, scaling, ordering, and validation messaging.
- Updates the FejerSecond reference test.
| File | Description |
|---|---|
src/grid/onedgrid.py |
Corrects Fejér weights and documentation. |
src/grid/tests/test_onedgrid.py |
Updates FejerSecond expected weights. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| nsum = npoints // 2 | ||
| j = np.arange(nsum - 1) + 1 | ||
| j = np.arange(nsum) + 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #336. There was a mismatch in the indices between the documentation and the implementation.