feat(devtools): split outbound UTM campaign into oss and cloud - #1134
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Devtools tagged every outbound CTA with one campaign (
openui_devtools), so referrals from OSS-only apps and from OpenUI Cloud apps were indistinguishable. The campaign is nowopenui_devtools_oss/openui_devtools_cloud.The surface is detected at runtime with no new dependency:
@openuidev/observability-cloudregisters its client onglobalThis[Symbol.for("openui.cloudObservability")], which is visible cross-bundle, so a liveclientthere means the app is on Cloud. Call sites that are inherently Cloud (the quota/billing CTAs) pass"cloud"explicitly.Changes
packages/devtools/src/lib/links.ts:DevtoolsSurface,detectDevtoolsSurface(), thirdsurfacearg onwithDevtoolsAttribution, per-surfaceutm_campaign"cloud"GLOBAL_KEYin observability-cloud noting devtools reads itTest Plan
pnpm --filter @openuidev/devtools test lint:check typecheck format:checkpass.@openuidev/observability-cloudhas a preexisting failure onmain(SDK_VERSION0.0.1 vs package.json 0.0.2), unrelated to this change.Checklist
surfaceis optional, so existing calls keep working; the campaign value changes, which analytics dashboards filtering onopenui_devtoolswill need to account forLink to Devin session: https://app.devin.ai/sessions/1e7e97b38afb400389badd2a24a786bd
Open in Devin Desktop: https://app.devin.ai/desktop/session/1e7e97b38afb400389badd2a24a786bd?variant=devin
Requested by: @zahlekhan