Add graphql support for taxonomy - #42
Open
adithyasamavedhi-ttd wants to merge 2 commits into
Open
Conversation
adithyasamavedhi-ttd
force-pushed
the
add-graphql-support-for-taxonomy
branch
9 times, most recently
from
August 25, 2026 23:45
0ba6244 to
5f9f0b3
Compare
legrigonis
reviewed
Aug 26, 2026
| ELEMENT_ID = os.getenv("GRAPHQL_EXAMPLE_ELEMENT_ID", "").strip() | ||
|
|
||
| # The token is passed per call, not baked into the client. | ||
| client = DataClient() |
Collaborator
There was a problem hiding this comment.
why not? Wouldn't it be the same token for most calls?
We might also want to use this same pattern to internalize oAuth2 token refresh automagically inside the client
GraphQL taxonomy operations (upsert_segments, upsert_segment, query_segments, query_segment_taxonomy_status) via a typed GraphQL client on DataClient, validated offline against the Impala subgraph SDL. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
adithyasamavedhi-ttd
force-pushed
the
add-graphql-support-for-taxonomy
branch
from
September 3, 2026 22:07
5f9f0b3 to
b4046d7
Compare
adithyasamavedhi-ttd
force-pushed
the
add-graphql-support-for-taxonomy
branch
from
September 3, 2026 22:35
b4046d7 to
7500d44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this MR do:
REST → GraphQL → SDK mapping
POST /v3/thirdpartydatamutation thirdPartyDataUpsert(input: [ThirdPartyDataUpsertInput!]!)→ThirdPartyDataUpsertResultsclient.third_party_taxonomy.upsert_segments(...)— 1–1000SegmentInputper callPUT /v3/thirdpartydatamode: CREATE | UPDATEper segmentclient.third_party_taxonomy.upsert_segments(...)— omit a key to leave that field unchangedPOST /v3/thirdpartydata/querythirdPartyDataProvider(id).thirdPartyTargetingDataSegments(where: {providerElementId: {in: [...]}}, first, after)client.third_party_taxonomy.query_segments(...)GET /v3/thirdpartydata/status/{providerId}/{providerElementId}where: {providerElementId: {eq: ...}}, selectingtaxonomyApprovalStatusclient.third_party_taxonomy.query_segment_taxonomy_status(...)Tests: