Skip to content

Fix broken NCC 2017 security audit link - #185

Merged
JustinCappos merged 3 commits into
theupdateframework:mainfrom
Labreo:fix/dead-ncc-audit-link
Aug 18, 2026
Merged

Fix broken NCC 2017 security audit link#185
JustinCappos merged 3 commits into
theupdateframework:mainfrom
Labreo:fix/dead-ncc-audit-link

Conversation

@Labreo

@Labreo Labreo commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

The NCC 2017 security audit link on the Security audits page was pointing to the defunct nccgroup.trust domain and was failing DNS resolution.

This PR updates the link to the active assessment page on nccgroup.com and removes the workaround exclusion from lychee.toml.

Updates the dead NCC Group audit link (.trust domain) to the active report page on nccgroup.com and removes the workaround exclusion from lychee.toml.

Signed-off-by: Labreo <74888611+Labreo@users.noreply.github.com>

@JustinCappos JustinCappos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link off of that page (to download the full report) doesn't seem to work, which is the main thing we actually want. I'd prefer a PR which moves the relevant content to our repo.

@Labreo

Labreo commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Noted.Will work and shift towards this.Will respond with my approach and get back to you soon.

@Labreo

Labreo commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

The download link on NCC's page seems to be broken internally. I’ve reached out to NCC to ask if they can restore the link or provide a copy of the report. I also tried checking the Wayback Machine, but the Internet Archive is currently down due to an outage.

In the meantime, does anyone on the team happen to have a copy of the report in the project archives? It should be titled "The Update Framework (TUF) Security Assessment" (also listed as "Kolide – The Update Framework Security Assessment").

If someone has it and can drop it here, I’ll add it under static/audits/ and update the links right away.

@Labreo

Labreo commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Managed to retrieve a copy of the file. Will add it and update this pr soon.

Hosts the 2017 NCC Group security assessment report locally in static/audits/
and updates the audit link in content/en/docs/security/audits.md.

Signed-off-by: Labreo <74888611+Labreo@users.noreply.github.com>
@Labreo

Labreo commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

I was able to track down a copy of the original 2017 report (ncc-group-kolide-the-update-framework-security-assessment.pdf).
I've added the PDF directly under static/audits/ (following the pattern of the X41 audit report) and updated the link in content/en/docs/security/audits.md.Please have a look as and when you find the time.

@Labreo
Labreo requested a review from JustinCappos August 18, 2026 08:58

@JustinCappos JustinCappos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for tracking this down and fixing it!

@JustinCappos
JustinCappos merged commit b5656b5 into theupdateframework:main Aug 18, 2026
7 checks passed
@Labreo
Labreo deleted the fix/dead-ncc-audit-link branch August 18, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants