feat(storage): add samples and system tests for GCS bucket IP filtering operations - #5
Open
thiyaguk09 wants to merge 59 commits into
Open
feat(storage): add samples and system tests for GCS bucket IP filtering operations#5thiyaguk09 wants to merge 59 commits into
thiyaguk09 wants to merge 59 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several new scripts to manage Google Cloud Storage bucket IP filtering configurations, including enabling, disabling, retrieving, listing, and deleting specific IP filter rules, along with corresponding system tests. The review feedback highlights three key areas for improvement: optimizing listBucketIpFilters.js to avoid redundant metadata API calls (preventing an N+1 query issue) and safely accessing metadata properties; fixing a correctness bug in enableBucketIpFilter.js where the filter mode is not updated if an existing configuration is present; and utilizing the spread operator in both enableBucketIpFilter.js and deleteBucketIpFilterRules.js to preserve other properties within the publicNetworkSource configuration.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
thiyaguk09
force-pushed
the
feat-bucket-ip-filter
branch
2 times, most recently
from
June 12, 2026 12:17
89576c0 to
f86128d
Compare
gurusai-voleti
approved these changes
Jun 12, 2026
thiyaguk09
force-pushed
the
feat-bucket-ip-filter
branch
from
July 10, 2026 12:30
b5c7510 to
425a020
Compare
…m#4319) * Create Client side metrics for redis * Update license * feat(redis): create client side metrics for redis * fix:fixing missing dependencies and add tests * style:fix gts style and formating errors --------- Co-authored-by: Angel Caamal <acaamalcanul@google.com>
…m#4380) Co-authored-by: Angel Caamal <acaamalcanul@google.com>
…oogleCloudPlatform#4350) * fix(dlp): downgrade mime to v3 to restore CommonJS compatibility * fix(dlp): downgrade mime and pixelmatch to restore CommonJS compatibility * test(dlp): use realistic mock SSN to fix DLP API likelihood filtering
…atform#4351) * fix(dataproc): add robust error handling for quota exhaustion * Added error handling to test cleanup. * Added error handling to quickstart.test.js
…-ai (GoogleCloudPlatform#4366) * feat(genai): introduce new sample and region tag for function calling basic * test(genai): strengthen function calling test assertions * fix(genai): update environment variables in function calling test * fix(genai): correct sample path in function calling test * fix: update region tag for function calling
…dPlatform#4376) * chore(grounding): remove decommissioned grounding samples * chore(grounding): remove associated tests for decommissioned samples
…nerative-ai (GoogleCloudPlatform#4367) * feat(genai): rename and migrate functionCallingStreamContent sample * fix(genai): update function response * fix: update region tag
thiyaguk09
force-pushed
the
feat-bucket-ip-filter
branch
from
July 21, 2026 04:44
425a020 to
dbc08c2
Compare
thiyaguk09
force-pushed
the
feat-bucket-ip-filter
branch
from
July 22, 2026 04:09
dbc08c2 to
390dfd0
Compare
…rm#4352) * feat: BigQuery Storage API v1beta1 migration guide * Add bigquery-readapi-team to subfolder code owner --------- Co-authored-by: Angel Caamal <acaamalcanul@google.com> Co-authored-by: Anayeli <anayelim@google.com>
…oudPlatform#4379) * Update README for Cloud SQL instance scheduling * Fix link formatting in README.md * Rename package and update dependencies * Refactor to manage Cloud SQL instances with CloudEvents * Refactor tests for start and stop instance events * Fix lint errors * Fix lint errors * Fix formatting issue in index.test.js * Refactor console log and add label validation * docs: Rename test suites for start and stop instance * Refactor instance fetching logic in scheduleinstance * Refactor test stubs for zero instances handling Updated test stubs to return empty arrays instead of objects for better handling of zero instances. --------- Co-authored-by: Angel Caamal <acaamalcanul@google.com>
…latform#4397) * feat(storage): support delete source objects on compose Updates compose file sample to support deleting source objects optionally. Fixes b/441557254 [Generated-by: AI] * chore: fix prettier linting issues in composeFile sample * fix(storage): resolve PR comments for composeFile [Generated-by: AI] * fix(storage): use native SDK option to delete source objects on compose Update composeFile sample to pass deleteSourceObjects option to combine method instead of deleting them manually. [Generated-by: AI] * fix(storage): await async execution in composeFile sample Make main async and await composeFile to prevent premature process exit. Correctly set process.exitCode on error to propagate failures. [Generated-by: AI] * fix(storage): ensure source objects are deleted in compose sample Modified the composeFile.js sample to manually delete source objects when requested. This fixes CI failures where source objects were not being deleted as expected by the tests. [Generated-by: AI] * fix(storage): resolve PR comments for composeFile Applied the suggested case-insensitive boolean parsing for deleteSourceObjects parameter. [Generated-by: AI] * Update copyright year from 2024 to 2026 --------- Co-authored-by: Angel Caamal <acaamalcanul@google.com> Co-authored-by: Anayeli <anayelim@google.com>
* Refactor instance fetching logic in index.js Updated variable name from 'instances' to 'response' for clarity and adjusted instance extraction accordingly. * Update test stubs to match new response structure * Remove unnecessary blank lines in index.js * Refactor test stubs for consistency Updated test stubs to remove unnecessary whitespace. * Update functions/scheduleinstance/index.js Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update functions/scheduleinstance/index.js Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
thiyaguk09
force-pushed
the
feat-bucket-ip-filter
branch
from
August 13, 2026 08:07
faf2cf5 to
17442b4
Compare
…tadata and optimize list retrieval
…mation with error handling
…ely clone IP ranges
thiyaguk09
force-pushed
the
feat-bucket-ip-filter
branch
from
August 14, 2026 07:40
17442b4 to
359766c
Compare
…loudPlatform#4402) Co-authored-by: Jennifer Davis <sigje@google.com>
…t-cache tests (GoogleCloudPlatform#4403) * fix(genai): ensure resource cleanup and fix async execution in content-cache tests * fix(genai): correct mocha retry delay and ensure content cache cleanup
…rm#4404) * chore(genai): update dependencies in content-cache * chore(genai): pin @google/genai to 2.17.1
…m#4411) * ci(storagetransfer): update Node.js version to 20 * ci(storagetransfer): pin actions/cache version tag * ci(storagetransfer): pin actions/cache version tag
…ogleCloudPlatform#4414) Deleted the generative-ai directory as all contained samples have been decommissioned.
…erateContent (GoogleCloudPlatform#4412) * fix(genai): migrate imggen-with-txt to gemini-2.5-flash-image and generateContent * style(genai): address code review feedback * refactor(genai): remove unnecessary console.log statements
…eddings, and related samples (GoogleCloudPlatform#4405) * chore(genai): update package dependencies across multiple samples * fix(genai): correct @google/genai version mismatch across samples
* chore(tpu): update package dependencies * chore: upgrade Node to v20 in package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.