Bump go-m1cpu to v0.2.1 to fix crash on Apple M5 Pro - #3537
Bump go-m1cpu to v0.2.1 to fix crash on Apple M5 Pro#3537lichtzeichner wants to merge 5 commits into
Conversation
|
I looked at the failing CircleCI build, and it seems that it was a broken CI cache key. |
Possibly fixed by thought-machine/please-servers#342 ? |
I don't think so. The issue I found was actually in the CircleCI config - but obviously this wasn't the issue causing the Segfault in CI. However, I'm unable to reproduce the CircleCI issue on an M4 Pro machine at all. Any Ideas what could cause this? |
|
I don't think this is still relevant any more? I can bootstrap fine on an M5 today, it looks like most of it has been merged in one way or another (apart from the circleci cache key thing, which is remarkably ancient). |
Originally found in #3537 - have split this out because that was overcome by various merge conflicts. This is ancient, it looks like it _should_ have changed to go.mod (probably when Go modules came out) but was missed, and has just hung around ever since.
|
Agree. I tested v17.31.2 - the build runs fine on my machine, and I also can run bootstrap.sh from a freshly cloned please repo. |
4 participants
Bump the go-m1cpu dependency to fix #3536