[pull] master from apify:master - #271
Merged
Merged
Conversation
…s` (#4021) `JSDOMCrawler` and `LinkeDOMCrawler` never passed the context-bound `enqueueLinks` into their enqueue-links helpers (unlike `CheerioCrawler`), so links were enqueued straight into the request queue and skipped the crawl depth tracking in `BasicCrawler`. `maxCrawlDepth` has therefore had no effect for these two crawlers since it shipped in v3.14.0. Both files already had the `BoundEnqueueLinksInternalOptions` machinery, it just was never reached. This wires it up the same way `CheerioCrawler` does, including the `limit` pre-clamp removal from #3927, which applies once the bound path is taken. Added crawl depth tests for both crawlers, mirroring the existing `CheerioCrawler` coverage. Replaces #4020, which targeted v4; the bug exists on v3 as well, so the fix lands here instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )