Update colours to match Bolt - #330
Conversation
…r as deprecated since the name used in design land is -surface and -critical. Also removed the -apmt, -send and -service specific colours.
devmount
left a comment
There was a problem hiding this comment.
This is awesome, thanks so much for improving the color management! 👏🏻 I found some smaller things and have some bigger questions, all noted below.
- Just to make sure: We are removing the
--colour-service-*and--colour-user-*props directly without deprecating them. Is this intentional? I'm not sure how much they are used in the services apps, so I'm fine with that. Also this PR is flagged as breaking anyway.- Appending to 1.: SyncCard still references
--colour-service-primaryand--colour-service-secondary. Should we replace them to avoid an undefined state? - Also: BaseButton still references
--colour-service-primary - Also: UserAvatar still references
--colour-user-blue - Also: LoadingSkeleton still references
--colour-user-graphite
- Appending to 1.: SyncCard still references
- Since the ColourPalette is a Storybook only component, should we remove the "Show Code" functionality?
Co-authored-by: Andreas <mail@devmount.de>
…quivalent colours
|
@devmount Thanks a lot for the reviews! You caught a lot of bits that I've missed here. So for the For the ones I've marked as deprecated, those are still used and could still continue to be used but they have mismatching names compared with what is on Bolt / Zeplin / Figma files. At least for me, the mismatch was confusing but it might take a little bit of time to adjust. Both Appointment & Send have their own copies of colours.css so the plan here when we release this is to go over both projects, remove the duplicated colours.css so that it can pull from services-ui directly and update any references of the outdated variables to the new ones. The one exception that I am aware of is Keycloak's theme in Accounts that also has a hard copy of the colours.css there but I believe it has to stay that way for build purposes :( |
devmount
left a comment
There was a problem hiding this comment.
Perfect, thanks for all the fixes and improvements.
Both Appointment & Send have their own copies of colours.css so the plan here when we release this is to go over both projects, remove the duplicated colours.css so that it can pull from services-ui directly and update any references of the outdated variables to the new ones.
Yes I think this a good way to go to get rid of deprecated and spreaded styles 👍🏻
|
Thanks! To keep up with design, I recommend a useless css variable that marks a version number/date/hash. Like
|
Oooo that's a good idea, we can try to keep that up-to-date with design changes. I've changed the name slightly to be |
What changed?
Warning
This is a breaking change.
--colour-surfaceand marked--colour-neutralas deprecated / to be removed once we've all migrated to the new names.--colour-send-*,--colour-apmt-*and--colour-service-*since we are moving away from service-specific colour palettes and towards a more unified look.Coloursstory for the Storybook (and a helper to render them) to visually check the colours.Why?
Limitations and Notes
--colour-danger-*and--colour-neutral-*are the most commonly used, there will be a moment until Send and Appointment are updated..csscolours form the projects while we're at it!-light-darkcolours for specific cases and those were kept.Applicable Issues
Closes #317
QA Log
Screenshots
Light mode:

Dark mode:
