Add SunIcon and MoonIcon components - #332
Merged
Merged
Conversation
devmount
requested changes
Sep 21, 2026
devmount
left a comment
devmount
left a comment
Collaborator
There was a problem hiding this comment.
Nice, thanks for adding those! I just found missing viewBox attributes. But other than that: working fine!
Co-authored-by: Andreas <mail@devmount.de>
Co-authored-by: Andreas <mail@devmount.de>
Contributor
Author
|
@devmount oh indeed, thanks for the suggestion! Interestingly, this was an export directly from Figma so I wonder if we somehow uncovered a bug on their end heh 🤔 |
devmount
approved these changes
Sep 21, 2026
devmount
left a comment
devmount
left a comment
Collaborator
There was a problem hiding this comment.
Looking great now, thanks! 🙇🏻
Haha good question on the Figma export. I made the experience that the export function in Figma sometimes differs depending on what is selected, so I'm not sure if that's the case here 🤷🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
SunIconandMoonIconcomponents + stories.Why?
Applicable Issues
Closes #331
QA Log
Screenshots
Light mode:
Dark mode:
