Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Warning
This is a breaking change.
Renamed
BaseButtonprops to remove the naming clash with the native HTML buttontypeattribute and make naming more intuitive:type(visual style) is renamed tovariantvariant(filled/outline) becomes a booleanoutlinepropformAction(the native button type) is now exposed astype(button/submit/reset)Updated the button wrapper components, Storybook stories,
README.mdexamples andBaseButton.test.jsaccordingly.Why?
Fixes the confusion raised in review of #168, where a custom
formActionprop was added because the existingtypeprop already meant "visual style" instead of the native button type.Limitations and Notes
Breaking change, see the migration guide below.
How to migrate
type(style) tovariantvariant="filled"(it's the default)variant="outline"with the booleanoutlinepropform-action="submit|reset|none"withtype="submit|reset|button"Applicable Issues
Closes #171
QA Log
pnpm run test:components: 530/530 tests passingpnpm run type-check: no errorspnpm storybookand manually checked the stories if everything renders correctlyScreenshots
No visual/CSS changes, only prop renames