Documents scale_*_date NA behavior #6868 - #6901
Open
melissa-gaughan wants to merge 2 commits into
Open
melissa-gaughan wants to merge 2 commits into
melissa-gaughan wants to merge 2 commits into
Conversation
thomasp85
requested changes
Sep 17, 2026
thomasp85
left a comment
thomasp85
left a comment
Member
There was a problem hiding this comment.
Thanks!
Can I get you to rerun documentation so that the Rd file is updated as well
teunbrand
reviewed
Sep 17, 2026
| #' output | ||
| #' @param limits One of: | ||
| #' - `NULL` to use the default scale range | ||
| #' - A numeric vector of length two providing limits of the scale. |
Collaborator
There was a problem hiding this comment.
If this is date-specific documentation, maybe we should change this recommendation from 'A numeric vector' to 'A date vector' or 'A date(time) vector' as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds clearer documentation on how to use NA as existing minimum or maximum in limits for datetimes.
Fixes #6868