Repository navigation
Remove dead PNG fallback from widget chart loading - #87
Merged
Merged
Conversation
loadChartBitmap kept a BitmapFactory.decodeFile branch for PNG chart files from the January design, when the Flutter app screenshotted its chart into a PNG for the widget. Both callers have passed pngPath = null since b795e3f (multi-aspect-ratio widgets), and nothing has written those files since charts moved to native SVG (#7), so the branch was unreachable. R8 couldn't drop it because MeteogramWidgetProvider is kept whole by a keep rule. Removing it also removes our only BitmapFactory call, which Play Console flags as "BitmapFactory without downsampling". The remaining calls in the release build are AndroidSVG's (embedded <image> data URLs, which our SVGs never contain) and Flutter's image decoders. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadChartBitmap kept a BitmapFactory.decodeFile branch for PNG chart files from the January design, when the Flutter app screenshotted its chart into a PNG for the widget. Both callers have passed pngPath = null since b795e3f (multi-aspect-ratio widgets), and nothing has written those files since charts moved to native SVG (#7), so the branch was unreachable. R8 couldn't drop it because MeteogramWidgetProvider is kept whole by a keep rule.
Removing it also removes our only BitmapFactory call, which Play Console flags as "BitmapFactory without downsampling". The remaining calls in the release build are AndroidSVG's (embedded![]()
data URLs, which our SVGs never contain) and Flutter's image decoders.
No behaviour change.