Skip to content

ci(hermes): fail the e2e when CI has no TinyFish key instead of skipping - #60

Open
Zechereh wants to merge 1 commit into
mainfrom
ci/hermes-e2e-require-key
Open

Zechereh wants to merge 1 commit into
mainfrom
ci/hermes-e2e-require-key

Conversation

@Zechereh

Copy link
Copy Markdown
Contributor
Change Why
e2e.sh exits 1 when TINYFISH_API_KEY is empty and CI is set a silent skip let the e2e pass without any live checks, which is how the Windows setup crash in #57 went uncaught

Local runs without a key still skip the live checks. Missed #59 because it was pushed after the merge.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 46d8e024-8dc9-44fb-b8b7-bc604d259fe5
📥 Commits

Reviewing files that changed from the base of the PR and between 1172d9c and 5e66bb2.

📒 Files selected for processing: 1
  • hermes/scripts/e2e.sh

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

📝 Walkthrough

When TINYFISH_API_KEY is unset and CI is non-empty, the end-to-end script reports an error and exits with status 1. Outside CI, it retains the existing successful skip.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 5e66b

CI runs fail when the API key is missing, while local runs can still skip the live checks. No merge-blocking risk remains.

Pre-merge checks: Passed 4
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly states the main change: CI now fails the Hermes e2e when TINYFISH_API_KEY is missing instead of skipping it.
Description check Passed The description directly explains the CI behavior change, the reason for it, and the unchanged local behavior.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant