reflect: implement NewAt - #5812
Open
jakebailey wants to merge 1 commit into
Open
jakebailey wants to merge 1 commit into
jakebailey wants to merge 1 commit into
Conversation
davecheney
approved these changes
Oct 3, 2026
Contributor
There was a problem hiding this comment.
LGTM.
@jakebailey I tried to send a PR to add davecheney@2e1a22b but your fork isn't configured for PRs. Feel free to cherry pick that if you like
Co-authored-by: Dave Cheney <dave@cheney.net>
jakebailey
force-pushed
the
reflect-new-at
branch
from
October 3, 2026 23:17
942dd66 to
14a61c9
Compare
Member
Author
|
Yeah, I figured it wasn't worth having that open 😄 Added your code and Co-authored-by'd it. |
davecheney
approved these changes
Oct 3, 2026
davecheney
left a comment
davecheney
left a comment
Contributor
There was a problem hiding this comment.
LGTM. let me know if you prefer a different way of sending patches. The PR on PR idea I shamelessly stole from @proppy.
Member
Author
|
I'm avoiding it mainly because I'm using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missing and is pretty easy to do. Unblocks some upstream stuff (eventually...)