Repository navigation
reflect: implement Slice3 and SetCap - #5815
Merged
Merged
Conversation
dgryski
approved these changes
Oct 1, 2026
dgryski
left a comment
dgryski
left a comment
Member
There was a problem hiding this comment.
LGTM. More reflect tests enabled 👍
jakebailey
force-pushed
the
reflect-slice3-setcap
branch
from
October 5, 2026 20:26
e924fc1 to
1278975
Compare
jakebailey
force-pushed
the
reflect-slice3-setcap
branch
from
October 6, 2026 05:02
1278975 to
9efdd09
Compare
Member
|
Thanks for the addition @jakebailey and to @davecheney for review. Now merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2494
Just a few tweaks to match upstream Go for these two.