Repository navigation
interp: name the function of a rollback from its instruction - #6014
Open
davecheney wants to merge 1 commit into
Open
davecheney wants to merge 1 commit into
davecheney wants to merge 1 commit into
Conversation
Each rollback site builds a recoverableError that records its message, the function being interpreted and, at two sites, the opcode of the failing instruction. errorAt already stores that instruction in the Error it returns, so every site repeats the function, which the Error can derive, and keeps the opcode apart from a message that could simply include it. This change adds rollbackAt, which builds a recoverableError from a message and wraps it with errorAt, and has Error name the function of any recoverable error when it is formatted. Rollback messages stay ad hoc, written where the rollback happens, and the two that name an opcode include it in the message. The messages are unchanged except that an instruction the interpreter does not model now names its opcode, and the remaining recoverable errors, such as an integer used as a pointer, now also name the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each rollback site builds a recoverableError that records its message, the function being interpreted and, at two sites, the opcode of the failing instruction. errorAt already stores that instruction in the Error it returns, so every site repeats the function, which the Error can derive, and keeps the opcode apart from a message that could simply include it.
This change adds rollbackAt, which builds a recoverableError from a message and wraps it with errorAt, and has Error name the function of any recoverable error when it is formatted. Rollback messages stay ad hoc, written where the rollback happens, and the two that name an opcode include it in the message. The messages are unchanged, and the remaining recoverable errors, such as an integer used as a pointer, now also name the function.