Repository navigation
build: CI toolchain fix, mold, aws-lc-sys shed, tokio-tungstenite 0.29 - #5453
Conversation
…inker setup Co-authored-by: Medulla <medulla@tinyhumans.ai>
…in the TLS policy Co-authored-by: Medulla <medulla@tinyhumans.ai>
…24 and thiserror 1.x from the kernel profile Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (24)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b7d99ca7d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7efed9ad36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| sub(/[[:space:]]*#.*/, "") | ||
| gsub(/^[[:space:]]+|[[:space:]]+$/, "") | ||
| if ($0 == table) found = 1 |
There was a problem hiding this comment.
When an existing $CARGO_HOME/config.toml uses Cargo's valid quoted spelling—such as [target.'x86_64-unknown-linux-gnu'] or [target."x86_64-unknown-linux-gnu"]—this exact string comparison misses it and appends the unquoted equivalent. TOML treats these spellings as the same table, so Cargo subsequently rejects the configuration as a duplicate declaration. Fresh evidence beyond the prior thread is that the added guard handles whitespace and comments but does not normalize quoted table keys; parse or recognize all equivalent spellings before modifying the file.
Useful? React with 👍 / 👎.
…\n\nbuild: CI toolchain fix, mold, aws-lc-sys shed, tokio-tungstenite 0.29\n
1 participant
Phase 1 of the build-time reduction program: three infrastructure quick wins with no product-surface change.
Changes
rust-toolchain.tomlpins 1.96.1, so every Rust job downloaded and installed a full toolchain before its first cargo call. All 17openhuman_ciimage references and 11 version-pinneddtolnay/rust-toolchainsteps now match, guarded by a newscripts/ci/check-toolchain-image.mjsdrift check wired into the Rust Quality lane. Also enables the already-installed-but-unused mold linker on the 9 Linux container jobs that run cargo, and addsscripts/dev-setup-linker.shfor opt-in local mold/lld setup (writes to$CARGO_HOME, never the repo config).aws-lc-sysshed — its sole activator was two dependency lines invendor/tinychannelsmissingdefault-features = false, unioning rustls's default aws-lc provider into every consumer graph despite the ring provider being installed explicitly at all call sites. Gone from both Cargo worlds; now forbidden byscripts/check-linux-tls-dependencies.sh. Kernel profile: 312/285/6 native → 304/281/5 native. Depends on fix(deps): stop pulling the aws-lc rustls provider tinychannels#14 (gitlink bumped here).thiserror1.x +thiserror-impl1.x proc-macro compile. The default profile still carries 0.24 transitively viasocketioxide0.15 (documented inkernel-floor.limits; a socketioxide bump is a separate follow-up). Depends on chore(deps): bump tokio-tungstenite to 0.29 in the Rust SDK tiny.place#273 (gitlink bumped here).Measured
scripts/kernel-floor.sh flows: 312 pkgs / 285 names / 6 native → 304 / 281 / 5 (ratchet written back).Ordering note
The workflow changes reference the image tag
openhuman_ci:rust-1.96.1, which does not exist yet —build-ci-image.ymlmust run and publish it before this PR's container jobs can go green.Part of the build-time reduction program; the Phase 2 deletions PR is stacked on this branch.