feat(harness): extract reusable run queue mechanics - #99
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Warning Review limit reached
Next review available in: 54 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe harness now exposes a thread-safe FIFO queue with steer, follow-up, and collect lanes. The OpenAI provider adds chat-template rejection detection with public re-export and tests. Harness documentation describes queue ownership and layout. ChangesActive-run queue
OpenAI error detection
Estimated code review effort: 3 (Moderate) | ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/modules/harness/README.md`:
- Line 169: Update the queue module reference in the documentation from
run_queue.rs to the run_queue/ directory, matching the added
src/harness/run_queue/mod.rs layout.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 1b010e59-0e3a-4e95-93ec-16892edc3d96
📒 Files selected for processing (9)
docs/modules/harness/README.mdsrc/harness/mod.rssrc/harness/providers/openai/local.rssrc/harness/providers/openai/local_test.rssrc/harness/providers/openai/mod.rssrc/harness/run_queue/mod.rssrc/harness/run_queue/test.rssrc/harness/run_queue/types.rssrc/lib.rs
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Summary
API Or Behavior Changes
Adds
RunQueue<T>,QueueLane,QueueStatus, andis_chat_template_rejection_messageas public APIs. Existing TinyAgents behavior is unchanged; these APIs let hosts reuse queue mechanics and local-runtime error recognition without importing host metadata.Tests
cargo fmt --checkcargo clippy --all-targets -- -D warningscargo clippy --all-targets --all-features -- -D warningscargo build --all-targetscargo build --all-targets --all-featurescargo testcargo test --all-featuresFocused additions cover empty queues, lane routing, FIFO/lane isolation, clearing, wrapped chat-template failures, case-insensitive matching, and unrelated provider errors.
Documentation
Updated
docs/modules/harness/README.mdwith the queue responsibility, source entry, and feature-ownership boundary.