Skip to content

fix(release): scope packaging to the published library - #12

Merged
senamakel merged 1 commit into
mainfrom
tinywallet-release-fix
Aug 11, 2026
Merged

fix(release): scope packaging to the published library#12
senamakel merged 1 commit into
mainfrom
tinywallet-release-fix

Conversation

@senamakel

Copy link
Copy Markdown
Member

The v0.2.0 release run failed at Package crate, before tagging or pushing anything, so main is untouched and no partial release exists.

error: failed to verify manifest at crates/tinywallet-module/Cargo.toml
Caused by:
  all dependencies must have a version requirement specified when packaging.
  dependency `tinywallet` does not specify a version

cargo package --locked with no -p verifies every default workspace member. That now includes tinywallet-module, whose path dependency on this crate carries no version — which is correct for a crate that is publish = false and ships as a release artifact rather than to crates.io, but fatal to a workspace-wide package step.

Both cargo package and cargo publish are now --package tinywallet. The library goes to crates.io; the module goes to the release bundles, which is the split the workflow already intended — the native-bundles job builds it separately with --package tinywallet-module.

This is a latent consequence of adding the workspace in #10: the step was fine when there was only one crate.

`cargo package --locked` verifies every default workspace member, including
`tinywallet-module` — whose path dependency on this crate carries no version.
That is correct for a crate that is `publish = false` and ships as a release
artifact rather than to crates.io, but it fails a workspace-wide package step:

    error: failed to verify manifest at crates/tinywallet-module/Cargo.toml
    all dependencies must have a version requirement specified when packaging

Scoping both steps with `--package tinywallet` publishes the library and
leaves the module to the bundle jobs, which is the split that was intended.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@senamakel, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 200fdcff-34fc-4ae5-b5cc-1e1b5f4a0c45

📥 Commits

Reviewing files that changed from the base of the PR and between 8e7548e and c3bc11e.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel merged commit 5b0a564 into main Aug 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant