fix(release): scope packaging to the published library - #12
Conversation
`cargo package --locked` verifies every default workspace member, including
`tinywallet-module` — whose path dependency on this crate carries no version.
That is correct for a crate that is `publish = false` and ships as a release
artifact rather than to crates.io, but it fails a workspace-wide package step:
error: failed to verify manifest at crates/tinywallet-module/Cargo.toml
all dependencies must have a version requirement specified when packaging
Scoping both steps with `--package tinywallet` publishes the library and
leaves the module to the bundle jobs, which is the split that was intended.
Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Warning Review limit reached
Next review available in: 54 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The v0.2.0 release run failed at Package crate, before tagging or pushing anything, so
mainis untouched and no partial release exists.cargo package --lockedwith no-pverifies every default workspace member. That now includestinywallet-module, whose path dependency on this crate carries no version — which is correct for a crate that ispublish = falseand ships as a release artifact rather than to crates.io, but fatal to a workspace-wide package step.Both
cargo packageandcargo publishare now--package tinywallet. The library goes to crates.io; the module goes to the release bundles, which is the split the workflow already intended — thenative-bundlesjob builds it separately with--package tinywallet-module.This is a latent consequence of adding the workspace in #10: the step was fine when there was only one crate.