Raise per-file coverage to 90% - #5
Merged
Merged
Conversation
The coverage.json file was being tracked unintentionally, so it has been added to .gitignore to prevent future commits from including generated coverage data. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Add three new test cases that verify the client correctly rejects malformed responses from EVM and Solana nodes. The EVM tests check that a non-string balance and a non-string transaction hash are both reported as malformed responses, and the Solana test verifies that missing blockhash fields and invalid signature strings are handled correctly. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Add two new test cases for the Tron client: one verifying that malformed account and transaction responses are correctly rejected with a MalformedResponse error, and another confirming that a successful broadcast returns the expected transaction ID. Also fix the Solana test to use explicit mnemonic and derivation path constants instead of the VECTOR and SOLANA_PATH variables. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Add two test cases that were missing from the test suite: one verifying that a Solana derivation path with a non-numeric segment is rejected, and another confirming that an EIP-155 chain ID causing a v-value overflow is properly rejected with an InvalidField error. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Updated the coverage.json file to reflect the latest test run results, which include changes in coverage percentages across multiple source files. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
…oadcast response Add two test cases: one verifying that a base58check value with the correct prefix but wrong length is rejected, and another ensuring that the Tron client correctly handles both a missing txid in the create transaction response and a malformed broadcast response body. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Updated the coverage.json file to reflect the latest test run results, ensuring the coverage report stays in sync with the current state of the codebase. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
The `validate_sender` function now trims the input and checks for empty addresses before parsing, and replaces the implicit `assume_checked` call with an explicit `require_network(Network::Bitcoin)` to ensure the address is on mainnet, returning a clear `WrongNetwork` error instead of panicking or silently accepting testnet addresses. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Changed the error construction in `validate_sender` to call `to_string()` on the trimmed address instead of `clone()`, since the address is already a `&str` and converting it to an owned `String` is more idiomatic than cloning a reference. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Reformatted several match arm patterns across the Tron address and client test files to use a multi-line layout with the `..` wildcard on its own line, improving readability and consistency with the project's existing style conventions. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
The function now returns an owned `String` instead of a borrowed `&str` for both the success and error paths, ensuring the caller does not need to manage lifetimes of the trimmed address slice. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Updated the coverage.json file to reflect the latest test run results, ensuring the coverage report stays in sync with the current state of the codebase. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Reformatted several function calls and assertion expressions across the BIP-32, Bitcoin, and test modules to improve code readability by breaking long lines and adjusting indentation. No functional changes were made. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
The test for derivation backend failures now exercises the compressed public key path by constructing a valid compressed key from an uncompressed private key, rather than injecting an artificial error. This ensures the error handling logic is tested against a realistic input that exercises the actual compression code path. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Reformatted the test code to reduce unnecessary line breaks and improve readability without changing any behavior. The change consolidates the function call chain into a more compact layout while preserving the exact same logic and error handling. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Replace the `#[allow(unreachable_patterns)]` attribute on the catch-all arm in both `validate` and `chain_enabled` with a `#[cfg(not(all(...)))]` condition that suppresses the arm only when all four chain features are enabled. This makes the unreachable pattern warning disappear at compile time rather than silencing it, ensuring the code correctly reflects which chains are actually compiled in. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
Removed the `test` module declarations from `src/address/mod.rs` and the corresponding test files, as these tests are no longer needed. The coverage data was updated to reflect the removal of these files from the coverage report. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
The coverage.json file was being tracked in the repository, but coverage data is a generated artifact that should not be version controlled. Removing it keeps the repository clean of build outputs and prevents unnecessary diffs on every test run. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Warning Review limit reached
Next review available in: 57 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR hardens address validation, key derivation error mapping, EVM transaction encoding, and client response validation. It adds targeted tests for malformed inputs, backend failures, overflow cases, and chain-specific response errors. ChangesValidation and error handling hardening
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raises all source and test files to at least 90% line coverage, reaching 96.59% overall line coverage.
Adds focused coverage for malformed client responses, Tron transactions, BIP-32/key-derivation failures, and EVM encoding safeguards. It also removes redundant address re-parsing and compiles feature-disabled dispatch fallbacks only when applicable.
Public API / behavior changes
None.
Validation
Related issue: none.
Summary by CodeRabbit
Bug Fixes
Reliability