Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdeque([0, 1, 2]).rotate(4)currently returns the original order instead of[2, 0, 1]: popping clamps at the deque length, so oversized rotations lose their remainder. Negative rotations have the same problem, and arbitrarily large integer steps fail inislice().Normalize the step count modulo the length before popping, preserving the direction so small left rotations remain small. Return an empty deque unchanged after validating the step via the integer-index protocol.
Tests compare positive and negative rotations with
collections.deque, including zero steps, multiple full turns, bounded and empty deques, unchanged original values, very large integers, and index-protocol inputs. The final regression suite has 13 failures on the base. After the fix on Linux / Python 3.12:This branch is based directly on master. It is independent of #335's slicing fix and leaves #331's remove/reverse maxlen fix untouched.