Skip to content

feat: accept notify_uid when adding or updating reminders - #274

Open
claytonjn wants to merge 1 commit into
todoist:mainfrom
claytonjn:reminder-notify-uid
Open

claytonjn wants to merge 1 commit into
todoist:mainfrom
claytonjn:reminder-notify-uid

Conversation

@claytonjn

Copy link
Copy Markdown

Context

  • The reminder and location reminder endpoints (create and update) accept notify_uid to choose which project collaborator receives the reminder, but the SDK methods don't expose it, so reminders can only notify the user creating them.
  • I'm adding reminders for project collaborators to the Home Assistant Todoist integration, which uses this SDK.

What was changed

  • add_reminder, update_reminder, add_location_reminder, and update_location_reminder accept an optional notify_uid keyword argument, in both TodoistAPI and TodoistAPIAsync.
  • The add and update tests send notify_uid. The update tests' args dicts are typed dict[str, Any] so mypy accepts the mixed value types.
  • Changelog entry under Unreleased.

Release

Home Assistant is on 4.0.1, and main holds the unreleased httpx2 migration. Would you consider cherry-picking this onto release/4.0.x for a 4.x release, as with #269 and #270? It applies cleanly there and the tests pass.

The reminders and location reminders endpoints accept notify_uid to choose
which project collaborator receives the reminder, but the SDK methods
didn't expose it.
@claytonjn
claytonjn requested a review from a team as a code owner November 13, 2026 20:24
@claytonjn
claytonjn requested review from amleczko and removed request for a team November 13, 2026 20:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant