Repository navigation
Conversation
The reminders and location reminders endpoints accept notify_uid to choose which project collaborator receives the reminder, but the SDK methods didn't expose it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
notify_uidto choose which project collaborator receives the reminder, but the SDK methods don't expose it, so reminders can only notify the user creating them.What was changed
add_reminder,update_reminder,add_location_reminder, andupdate_location_reminderaccept an optionalnotify_uidkeyword argument, in bothTodoistAPIandTodoistAPIAsync.notify_uid. The update tests'argsdicts are typeddict[str, Any]so mypy accepts the mixed value types.Release
Home Assistant is on 4.0.1, and main holds the unreleased httpx2 migration. Would you consider cherry-picking this onto
release/4.0.xfor a 4.x release, as with #269 and #270? It applies cleanly there and the tests pass.