Skip to content

docs(mcp): fix stale MCP tool count in Codex example - #1104

Open
jiashuoz wants to merge 1 commit into
mainfrom
claude/relaxed-cerf-v9yiyb
Open

jiashuoz wants to merge 1 commit into
mainfrom
claude/relaxed-cerf-v9yiyb

Conversation

@jiashuoz

Copy link
Copy Markdown
Member

Summary

Scheduled documentation audit pass (Markdown-only). Before starting, I checked open PRs/branches per the audit's step 0: #1092, #1096, and #1101 already cover remaining AGENTS.md gaps (package inventory, CLI command list, Auth package list) — excluded here. I also re-verified the one closed-but-unmerged branch touching docs (claude/relaxed-cerf-nzxqy4 / PR #1037, closed for drift): its update_protection "fix" was actually a misreading — the JSON in plugins/e2a/docs/setup.md / SKILL.md documents the MCP tool's flat argument shape (confirmed against mcp/src/tools/agents.ts), not the REST API's nested ProtectionConfigRequest body, so no change was needed there.

  • mcp/examples/codex/README.md — said e2a's MCP tools are "78 total," but the actual registered total is 80 (mcp/tests/tools.test.ts: RUNTIME_TOOLS.size === 21, ADMIN_TOOLS.size === 59, full account-scope set === 80), matching the count already used in docs/runbooks/mcp-server.md, plugin.json, and marketplace.json. This file was last touched in PR docs: document e2a metrics CLI command, fix stale MCP tool counts #905 (Aug) and missed a subsequent tool addition.

I also audited CONTRIBUTING.md, docs/deployment.md, docs/observability.md, docs/data-handling.md, docs/events.md, SECURITY.md, the examples/* READMEs, and the other mcp/examples/* READMEs against current code/config and found no further high-confidence issues — this repo's docs are already very thoroughly kept in sync.

No behavior changes — Markdown only.

Operational risk

None — a single stale number in an example README; no code paths touched.

Test plan

  • Verified actual MCP tool total against mcp/tests/tools.test.ts (RUNTIME_TOOLS=21, ADMIN_TOOLS=59, full set=80)
  • Confirmed consistency with docs/runbooks/mcp-server.md, plugins/e2a/plugin.json, .claude-plugin/marketplace.json

Generated by Claude Code

The Codex MCP example claimed 78 total tools, but the actual registered
total (per mcp/tests/tools.test.ts) is 80 — matching the count already
used in docs/runbooks/mcp-server.md, plugin.json, and marketplace.json.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LC5BiEDPtPY2r9CKxjYT9B
@jiashuoz jiashuoz self-assigned this Nov 16, 2026

Copy link
Copy Markdown
Member Author

The "Go coverage gate" failure here isn't caused by this diff (a single Markdown line, no Go code touched). Root cause, from the job log:

failed loading config from file: failed parsing config file: yaml: unmarshal errors:
  line 9: field local-prefix not found in type testcoverage.Config

.github/workflows/test.yml pins vladopajic/go-test-coverage@v2 — a floating major-version tag — which has resolved to v2.23.0 and apparently dropped/renamed the local-prefix key that .testcoverage.yml:9 still uses. This breaks config parsing before any coverage is even computed, so it fails on every PR regardless of diff — confirmed independently on #1101 (an unrelated AGENTS.md-only PR), which shows the identical failure.

Leaving this as-is since it's an unrelated, repo-wide CI/infra break outside this docs PR's scope — flagging it for a maintainer to pin the action to a compatible version (or update .testcoverage.yml for the new schema) separately.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants