Conversation
The section names a `sub` parameter that does not exist (the parameter is `subset`), and states a containment requirement that has not held since tokio-rs#355, which made an empty `subset` always succeed. Two tests in tests/test_bytes.rs already assert the behaviour the docs deny.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
# Panicssection onBytes::slice_refis wrong twice over:sub; the parameter issubset, which the rest of the doc comment already uses.`sub`appears nowhere else insrc/.subsetdoes not panic even when it is outside the buffer —slice_refreturns early. The repo's ownempty_slice_ref_catches_not_an_empty_subsettest asserts exactly that.Fixed both.