Preserve buffer order in Chain::chunks_vectored - #855
Open
RanaPriyansh wants to merge 1 commit into
Open
RanaPriyansh wants to merge 1 commit into
RanaPriyansh wants to merge 1 commit into
Conversation
RanaPriyansh
force-pushed
the
fix/chain-vectored-order-701
branch
from
September 24, 2026 09:45
095f318 to
eb6f563
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #701.
Chain::chunks_vectoredcan expose the second buffer before all bytes from the first buffer. For example, a valid partial buffer can returnhworldwhenhellois chained toworld.Append second-buffer slices only when the first-buffer slices cover all its remaining bytes. Complete buffers retain vectored reads across both buffers.
The regression checks that each vectored read returns a logical prefix. Tests also cover repeated reads with advancement, complete buffers, empty buffers, empty and single-slot destinations, and nested chains.
Validation:
cargo fmt --all --checkandci/test-stable.sh testpass on Rust 1.97 withRUSTFLAGS=-Dwarnings. The stable script covers default, individual, optional, and all features. It includes the adjacent buffer and take tests.MSRV 1.57, pinned nightly, Miri, Loom, sanitizers, and other platform checks were not run locally. This contribution was prepared with AI assistance.