Conversation
- Set `Access-Control-Allow-Origin` to `*` instead of echoing request header - Update `CorsRequestHandlerTest` to assert wildcard origin Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Set `Access-Control-Allow-Origin` to `*` instead of echoing request header - Update `CorsRequestHandlerTest` and `AbstractITTusFileUploadService` to assert wildcard origin Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
|
coverage: 94.667% (-0.01%) from 94.679% — bugfix/cors-origin-reflection-6803265430144852735 into master |
2 participants
🚨 Severity: HIGH
💡 Vulnerability: The
CorsRequestHandlerwas mirroring the arbitraryOriginheader supplied by incoming requests back in theAccess-Control-Allow-Originresponse header.🎯 Impact: This permitted ANY cross-origin domain to bypass Same-Origin Policy protections (Arbitrary Origin Reflection/CWE-942). In combination with lacking
Vary: Originheader, this can lead to cache poisoning in intermediate CDNs causing DoS.🔧 Fix: Updated the default CORS configuration to use a safe, explicitly permissive wildcard (
*) instead of reflecting unvalidated user input.✅ Verification: Tested via unit tests using
mvn clean testandmvn verify -Pcheck-coverage -Djacoco.compare.branch=master.PR created automatically by Jules for task 6803265430144852735 started by @tomdesair