Fix BlackSheep cross-task database access#2248
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
BlackSheep initializes the ORM in its lifespan task, but request tasks could not see that context because the global fallback was disabled. Enable the same fallback used by the other ASGI integrations and add a regression test for the startup configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable the global context fallback when the BlackSheep integration initializes Tortoise.
Motivation and Context
BlackSheep startup and request handlers run in separate asyncio tasks. Without the fallback, every request-side database query raises
No TortoiseContext is currently active. Fixes #2244.How Has This Been Tested?
The regression test fails without the flag and passes with it. A BlackSheep lifecycle probe also initialized the ORM in one task and successfully queried SQLite from another.
Checklist: