Conversation
- src/macros/test.md: the `#[sqlx::test]` fixtures example pointed at `examples/postgres/social-axum-with-tests`, which does not exist. The directory is `examples/postgres/axum-social-with-tests`. - sqlx-cli/README.md: `sqlx migrate add` creates `migrations/<timestamp>_<name>.sql`, not `<timestamp>-<name>.sql`. The separator is an underscore, as the reversible-migration example further down the same file already shows. - sqlx-postgres/src/options/pgpass.rs: "Superfluous escape in in pgpass file" warning had a doubled "in"; the two sibling warnings in the same function are already correct. - examples/sqlite/extension/sqlx.toml: "the full path the the extension" -> "the full path to the extension". - examples/postgres/axum-social-with-tests/Cargo.toml: "Auxilliary" -> "Auxiliary". - sqlx-cli/tests/migrate.rs: doubled "to" in a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six documentation/comment corrections, two of which are wrong enough to mislead a reader following the docs.
src/macros/test.md— the#[sqlx::test]fixtures walkthrough points readers atexamples/postgres/social-axum-with-tests, but the directory in this repo isexamples/postgres/axum-social-with-tests. The two words are transposed, so anyone following the pointer hits a dead path.sqlx-cli/README.md— thesqlx migrate addsection says the new file is created atmigrations/<timestamp>-<name>.sql. The separator is an underscore:sqlx-cli/src/migrate.rsbuilds the name withfile_name.push('_'), and the reversible-migration example further down the same README already showsmigrations/20211001154420_<name>.up.sql.sqlx-postgres/src/options/pgpass.rs— the warning"Superfluous escape in in pgpass file"has a doubledin. The two sibling warnings in the same function ("Superfluous escape in pgpass file" and "Superfluous escape at EOL in pgpass file") are already correct, so this one is just a slip.The rest are small:
examples/sqlite/extension/sqlx.toml— "Provide the full path the the extension" → "the full path to the extension".examples/postgres/axum-social-with-tests/Cargo.toml— "Auxilliary" → "Auxiliary".sqlx-cli/tests/migrate.rs— doubled "to" in a comment.No functional changes: the only non-comment edit is the text of one
tracing::warn!string, which nothing asserts against.