Post to satis with auth - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the old unauthenticated satis trigger (the jbrooksuk/laravel-forge-action action posting to a bare SATIS_TRIGGER_URL secret) with an authenticated curl POST using HTTP Basic Auth, mirroring the fix already applied in transformstudios/prime PR #772 ("Package updates need to post w/ auth"). The old endpoint was found to be open to the world with no authentication, so this closes that gap.
Important: this repo currently has NO relevant Actions secrets at all. I confirmed this via
gh api repos/transformstudios/statamic-front/actions/secrets, which returned an empty list ({"total_count":0,"secrets":[]}). It is missing SATIS_TRIGGER_URL, SATIS_TRIGGER_AUTH_USER, and SATIS_TRIGGER_AUTH_PASS, all of which need to be added to the repo (or org) secrets before this workflow will work at all. Please add those secrets before merging, otherwise the workflow will fail on the next run.