Repository navigation
fix: Forward declare the Option parseHook - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseHookforOption[T]is defined atsrc/jsony.nim:494,but it is missing from the forward declaration block at the top of the file.
When
parseObjectInnerline 389, bindsparseHookfor a field of typeOption[T], the Option overload is not yet in scope,overload resolution then selects
parseHook*[T: object|ref object]instead, becauseOptionis an object.The object hook starts with
eatChar(s, i, '{'), so parsing any object with anOptionfield can fail with:Declaring the Option hook alongside the others fixes the binding.