Repository navigation
check_decode: print a PXF rejection with its line:col, as protowire-go does - #146
Merged
Merged
Conversation
trendvidia
force-pushed
the
check-decode-position-145
branch
from
November 4, 2026 19:17
0802fc8 to
4b516a6
Compare
Collaborator
Author
trendvidia
force-pushed
the
check-decode-position-145
branch
from
November 4, 2026 22:52
4b516a6 to
cd52edd
Compare
Collaborator
Author
trendvidia
force-pushed
the
check-decode-position-145
branch
from
November 5, 2026 04:19
cd52edd to
1695e1d
Compare
Collaborator
Author
|
Rebased onto main 9b9860a: cd52edd → 1695e1d. The earlier red "Differential against protowire-go" was |
trendvidia
force-pushed
the
check-decode-position-145
branch
from
November 5, 2026 06:49
1695e1d to
59fc070
Compare
Collaborator
Author
|
Rebased onto main 96edbdd, after #139 merged, to clear a CHANGELOG.md conflict: 1695e1d → 59fc070. The code is unchanged, and the CHANGELOG still gets one added line. Locally: build OK, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145.
check_decodeprinted a PXF rejection without its position. protowire-go printsreject: L:C: msg. The library already keeps the position on theStatus, soPxfDecodeandPxfPbnow printStatus::ToString(), which givesline:col: msg. The PB and SBE paths carry no position and are unchanged.Evidence (macOS, on main a632c6e):
check_decode_position_pxfandcheck_decode_position_pxf-pbrun the binary ontestdata/check_decode/unknown-field.pxfand expectreject: 3:3: unknown field "nope" in test.v1.AllTypes. That is the text protowire-go's check_decode prints for the same input, measured on check_decode: a PXF rejection leaves out the line:col prefix that protowire-go prints #145.main.ccrestored, both tests fail (Required regular expression not found). With the fix, both pass.ctest: 100% passed, 658 of 658.No gate verdict changes. The spec's
cross_security_check.shsends check_decode's output to/dev/nulland judges by exit code alone, which this PR leaves unchanged (read in the script at spec main 0317811).