Skip to content

Re-sync the vendored shared schemas with protos v0.1.2 - #49

Merged
trendvidia merged 1 commit into
mainfrom
sync-protos-v0.1.2
Oct 31, 2026
Merged

trendvidia merged 1 commit into
mainfrom
sync-protos-v0.1.2

Conversation

@bfrancojr

Copy link
Copy Markdown
Collaborator

Part of trendvidia/protowire#447.

The vendored .proto copies now match trendvidia/protos v0.1.2 from syntax down. Each file keeps its own license header. They gain protos' file options (go_package, java_package, java_multiple_files, csharp_namespace), and envelope.proto no longer names a Go package that was never published.

Evidence

  • Each copy compiled with protoc before and after: the descriptors are identical once file-level options are removed. A deliberate field-number change in one copy showed up as a difference.
  • cmake -S . -B build && cmake --build build -j && ctest --test-dir build: 100% of 298 tests passed. C++ generates at build time, so no generated file changes.

Everything from `syntax` down now comes from trendvidia/protos v0.1.2,
which adds file options. Declarations and field numbers are unchanged:
protoc descriptors match before and after, file options aside.
@trendvidia
trendvidia merged commit 4dda38b into main Oct 31, 2026
10 checks passed
@trendvidia
trendvidia deleted the sync-protos-v0.1.2 branch October 31, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants