Skip to content

Report the default's literal as Violation.name for required-with-default #30

Open

Description

@bfrancojr

Problem

Violation.name for (pxf.required) with (pxf.default) on one field must hold the (pxf.default) literal, as the owner decided in trendvidia/protowire-go#211. Python reports the bare field name today, on main and in the open release PR #29.

Why it isn't done yet

#29 removes the local check and takes violations from protowire-cpp, deriving the name in the bridge because cpp leaves it empty (cpp leaves name empty here). The cpp fix is in trendvidia/protowire-cpp's open PR and isn't released, so this needs that release in the pin first.

Done when

  • The pinned protowire-cpp carries the fix.
  • The bridge passes cpp's name through, and the line deriving it from element is gone.
  • tests/test_pxf_required_default.py expects the literal.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions