Repository navigation
Conversation
protowire-cpp now fills name in, so the bridge passes it through instead of deriving the field name from element. The workflows pin protowire-cpp by commit until v1.2.1 is tagged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30
Violation.namefor(pxf.required)with(pxf.default)on one field now holds the default's literal, as decided in trendvidia/protowire-go#211. Python was the last port reporting something else.Draft, because of the pin. protowire-cpp's fix isn't in a tag:
v1.2.1hasn't been cut. The three workflows pin protowire-cpp to4e92e324c0226b815f51b76311fd1bf6b0ffeaf5so CI can prove this, and that is the commitv1.2.1is intended for. It should becomePROTOWIRE_CPP_REF: v1.2.1before merge, becausepublish.ymlbuilds wheels from this ref.Evidence
4e92e32:pytestgives 104 passed, 5 skipped.v1.2.0, the required-with-default tests fail, which shows the build used the pinned checkout and the tests depend on the fix.name, pinned bytest_empty_default_gives_an_empty_name.