Skip to content

Repair issue #8 managed callback failure coverage - #10

Merged
grove merged 2 commits into
mainfrom
issue/8
Oct 5, 2026
Merged

grove merged 2 commits into
mainfrom
issue/8

Conversation

@grove

@grove grove commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Summary

This standalone follow-up for issue #8 repairs the R3 managed-worker callback-failure regression. The test registers the S1 failure callback and reaches it through BackgroundWorker::transaction; the callback fails with SQLSTATE P0001, the worker resets and recovers for a later cycle, and public case, receipt, and source vectors remain unchanged.

  • Retains the accepted core claim, adjacent 0.46.1 SQL maintenance package, and managed-worker grant behavior.
  • Exercises the actual registered callback failure path and removes the obsolete direct failure fixture.
  • Keeps the broader S1 release decision blocked. This PR does not complete issue v0.49.0: Deliver managed deadlines and bounded escalation #8 or claim S1 release readiness.

Evidence

  • REVIEWED: .p2p/work/issue-8-core-claim-maintenance/review.md, SHA-256 090410c8b89cfcb855f4cb3e3606cab27dd0d3bdef8a30d1b9d6c2a00f89977a; all R1–R5 reviewed with no material findings.
  • PROVEN: .p2p/work/issue-8-core-claim-maintenance/proof.md, SHA-256 930b0670c33efe0b451b8148bb83fdf986c8a1c8b28ab9b4b4e4fe9163b39c39; all five maintenance requirements proven for the exact f44 candidate.
  • Managed audit: 19/19 checks passed, including the registered callback failure, SQLSTATE P0001, role reset, worker recovery, and unchanged public state. Evidence SHA-256 57b0283c46a983dee99644c1e340df3603178883b842988f95779c28fc15ed91.
  • Static maintenance checks: exact append and reproducible assembly; SHA-256 04dbb5ddd6fb6d45848ec8fc94a453cd41e4497f3b3ff5e162ed0344ed2e4b0b.
  • Qualification rebuild receipt: SHA-256 1d34ec23a61c0233e2e0e2eded7838111f823992ef70fbbde35bfaecc0a9e060. The image was rebuilt from recorded inputs; the previous image ID was unavailable. It includes a local, unreleased pg_trickle candidate. Upstream v0.108.2 is now released and contains MAINTAIN-grantee refresh support from PR #1151, in commit f76e46c. This pg-react qualification evidence has not yet been rebuilt or rerun against that exact release.

The broader S1 disposition remains INPUT_BLOCKED pending qualification of this candidate against released pg_trickle v0.108.2, 1000-case and churn measurements, owner-confirmed complete fixtures, and signed numeric operating limits. The release contains the MAINTAIN-grantee refresh support needed by this maintenance lane, but the retained qualification used a local unreleased upstream candidate. This PR does not close issue #8.

Review comparison

  • Candidate C: snapshot:sha256:f44d3184c29a6e5eb9d16db83da74f2e5df4ff28e28e9f3d4ca6cf4c400d3e49.
  • Frozen review comparison base A: c9c20778ec3b9e4783e71688678d24ca91958716.
  • Observed destination tip D on main: a44777f0d6fe22c7319c5ac2f562a420cb97e949, a fast-forward descendant of A with four commits ahead in the repository comparison, including merged PR Repair shared claim and managed worker grants for #8 #9.
  • Existing PR Repair shared claim and managed worker grants for #8 #9 merged the prior candidate snapshot:sha256:27adf692841308ae79f54f5336b76dc39a8270e94ed31a28f693a41f42db2ac4; this preview identifies the new f44 candidate and a separate draft PR.
  • Candidate C and current D differ in tests/integrations/pg-mdm/time/audit.py, tests/integrations/pg-mdm/time/idle.sql, and deletion of tests/integrations/pg-mdm/time/role-reset-on-error.sql.
  • Proposed publication commit: one commit with tree C and parent A, subject Repair issue #8 managed callback failure coverage.

The reports prove and review C against A only. They do not assess compatibility with commits after A or merge readiness against D. With parent A, the draft PR comparison may include the full A-to-C changes even where current main already has matching content; the three-path C-to-D delta and any merge behavior have not received separate review.

Merge readiness: NOT ASSESSED.

Merge Danger

Door: Two-way

Blast Radius: Managed-worker callback failure coverage, maintenance qualification evidence, and the existing core claim and 0.46.1 maintenance package.

@grove
grove marked this pull request as ready for review October 5, 2026 07:40
@grove
grove merged commit 3376934 into main Oct 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant