Drop the codeclimate-test-reporter development dependency - #684
Merged
Conversation
`CodeClimate::TestReporter.start` only starts SimpleCov when `CODECLIMATE_REPO_TOKEN` is set. Nothing in this repository sets it, so the call has been a no-op: no coverage was measured and nothing was reported. The gem is also deprecated upstream. codeclimate/ruby-test-reporter was archived on 2025-07-19 and its README points at the unified test reporter; its last release, 1.0.9, is from 2018, and the gemspec pinned `~> 0.6.0`, older still. Removing it also drops simplecov, simplecov-html and simplecov_json_formatter from the development bundle. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
tricknotes
force-pushed
the
drop-codeclimate-test-reporter
branch
from
September 12, 2026 02:58
35e8574 to
4e51aaf
Compare
tricknotes
marked this pull request as ready for review
September 12, 2026 03:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec/spec_helper.rbhas started a Code Climate test reporter on every run since 2015. It has never reported anything.It is a no-op here
CodeClimate::TestReporter.startstarts SimpleCov only when the reporter decides to run, and that decision needs an environment variable:Nothing in this repository sets
CODECLIMATE_REPO_TOKEN— not.github/workflows/tests.yml, notbin/setup, not the Rakefile. There is no.codeclimate.ymland no badge in the README. Running the two lines fromspec_helper.rbas they stand:So SimpleCov never starts, no coverage is measured, and nothing is uploaded. The
/coverage/entry in.gitignorehas been guarding a directory that is never written.It is deprecated upstream
~> 0.6.0, older still.Changes
spec/spec_helper.rb: drop therequireand thestartcallember-cli-rails.gemspec: drop the development dependencyNo
CHANGELOG.mdentry: this is a development dependency and nothing an application using the gem can observe changes.Gemfile.lockis not committed, so there is nothing to regenerate here. Locally the removal also dropssimplecov,simplecov-htmlandsimplecov_json_formatterfrom the development bundle.Tests
bin/rspec spec/libgives the same result before and after: 174 examples, 2 failures. Both failures (app_spec.rb:192,app_spec.rb:200) are present onmainand neednode_modulesinstalled to find theemberbinary.