Accept generator_spec 0.10.0 - #685
Merged
Merged
Conversation
The development dependency pinned `~> 0.9.0`, which rejects 0.10.0 — released the same day as 0.9.5, on 2024-01-25. The library difference between the two is additive: 0.10.0 adds a `does_not_contain` matcher to `have_structure` and a failure message for it. Nothing existing changed, and its runtime requirements are unchanged at `activesupport >= 3.0.0` and `railties >= 3.0.0`. `spec/generators` passes against 0.10.0: 15 examples, 0 failures. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~> 0.9.0rejects 0.10.0, which was released on 2024-01-25 — the same day as 0.9.5, the newest version the pin allows.The difference is additive
Diffing the two gems'
lib/directories,0.10.0adds adoes_not_containmatcher tohave_structureand a failure message for it:Nothing was removed or changed in what
have_structure,destination,run_generatororprepare_destinationalready did, and the runtime requirements are the same in both versions:activesupport >= 3.0.0andrailties >= 3.0.0.Tests
With
generator_spec 0.10.0resolved locally:bin/rspec spec/generators— 15 examples, 0 failuresbin/rspec— same 6 failures as onmain, all from the dummy Ember application not being built in this environmentNo CHANGELOG entry
This is a development dependency, so nothing an application using the gem can observe changes.