Repository navigation
ci(smoke-test): pick the token by the release under test (TRUNK-23149) - #1335
Merged
Merged
Conversation
#1314 moved the release smoke test to the v2 API keys, but it runs the latest published CLI and gem (0.17.0), which send --token as an organization token. trunk1 finds no org for a v2 key, so createBundleUpload and the quarantine lookup 404 on staging and production. determine_releases now records whether each release is 1.0.0 or later. Releases before 1.0.0 get the organization token, and later ones get the v2 key, so the run switches over when 1.0.0 is published. The gem jobs now list determine_releases in needs so they can read that output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
😎 Merged successfully - details. |
acatxnamedvirtue
approved these changes
Nov 17, 2026
Collaborator
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release smoke test has failed since 14:00 UTC on 2026-11-17 (run), on staging and production, for the CLI and the Ruby gem.
#1314 moved
smoke_test.ymltoTRUNK_{PROD,STAGING}_API_V2_TOKEN. This workflow runs the latest published release, which is still 0.17.0, and 0.17.x sends--tokenonx-api-tokenas an organization token. trunk1'sGetOrganizationByApiTokenfinds no org for a v2 key, andGetOrganizationByUrlSlugthen returnsPERMISSION_DENIED. The public API maps that to 404 on/v1/metrics/createBundleUpload, and the CLI reports "Unauthorized access…". The quarantine lookup fails the same way. Customer traffic is unaffected: production 404s on that route are at their usual background level.Change
determine_releasesoutputscli_v2/rspec_v2, which are true when the release's major version is 1 or higher. The CLI and gem get separate outputs because a manual run can setreleaseandrspec_releaseto different versions.TRUNK_{PROD,STAGING}_ORG_API_TOKEN, org-level secrets) otherwise.test_ruby_gem_{staging,production}now listdetermine_releasesinneeds, because a job can only read outputs from jobs it lists directly. Without it, the expression would be empty and the jobs would stay on the org token after 1.0.0.When 1.0.0 is published, the run switches to the v2 keys with no further PR.
smoke_test_main.ymlbuilds frommain, which already only accepts v2 keys, so it is unchanged.Testing
0.17.0,0.17.0-beta.4andv0.16.3, and true for1.0.0,1.0.0-beta.1,1.0.0.pre.beta.1and2.3.4.main, and nothing new.trunk checkcouldn't run in this environment (no Rust toolchain), so it was not run.🤖 Generated with Claude Code
Part of TRUNK-23149